feat: redact unknown paths by default in chiware StatMiddleware #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atzoum
reviewed
Jun 7, 2023
saurav-malani
force-pushed
the
fix.reqStatsTagCardinality
branch
from
288c00f
to
df13090
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
- Coverage 78.02% 77.90% -0.12%
==========================================
Files 56 55 -1
Lines 3558 3526 -32
==========================================
- Hits 2776 2747 -29
+ Misses 646 643 -3
Partials 136 136
☔ View full report in Codecov by Sentry. |
atzoum
changed the title
atzoum
reviewed
Jun 8, 2023
atzoum
approved these changes
Jun 8, 2023
lvrach
approved these changes
Jun 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
StatMiddleware, by default will now use for unmatched paths the value
/redactedin thereqTypetag. This can guarantee that captured stats don't introduce a tag cardinality issue. This default behaviour can be overridden through theRedactUnknownPathsoption.Additional changes
Removed the
gorillawarepackageNotion Ticket
https://www.notion.so/rudderstacks/Filter-metrics-endpoint-path-in-gateway-7ac54cf219c64fc3b44e14ea89df1918?pvs=4
Security